Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom naming for multi output primitives #780

Merged
merged 9 commits into from Oct 30, 2019
Merged

Custom naming for multi output primitives #780

merged 9 commits into from Oct 30, 2019

Conversation

thehomebrewnerd
Copy link
Contributor

Pull Request Description

Updates to allow for custom naming of multioutput primitives. Implements a generate_names method in PrimitiveBase class that can be overridden when creating a custom primitive.

This change was discussed in Issues #591 and #593.

@CLAassistant
Copy link

CLAassistant commented Oct 18, 2019 •
edited

CLA assistant check
All committers have signed the CLA.

rwedge
rwedge reviewed Oct 24, 2019
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think GroupByTransformFeature should also implement generate_names

featuretools/primitives/base/aggregation_primitive_base.py Outdated Show resolved Hide resolved
featuretools/primitives/base/transform_primitive_base.py Outdated Show resolved Hide resolved
rwedge
rwedge reviewed Oct 25, 2019
View reviewed changes
docs/source/changelog.rst Outdated Show resolved Hide resolved
rwedge
rwedge reviewed Oct 30, 2019
View reviewed changes
featuretools/tests/primitive_tests/test_groupby_transform_primitives.py Outdated
f = 'MULTI_CUM_SUM(age) by région_id[%d]' % i
f = 'MULTI_CUM_SUM(age)[%d] by région_id' % i
assert f in fm.columns
for x, y in zip(fm[f].values, correct_answers[i][1].values):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this test, can we also calculate the standard groupby features in a separate DFS call and compare, to see if the multioutput code path alters any values?

@thehomebrewnerd thehomebrewnerd mentioned this pull request Oct 30, 2019
Closed
rwedge
rwedge approved these changes Oct 30, 2019
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@thehomebrewnerd thehomebrewnerd merged commit 6094a68 into master Oct 30, 2019
@thehomebrewnerd thehomebrewnerd deleted the multi-out-names branch October 30, 2019 16:03
@thehomebrewnerd thehomebrewnerd mentioned this pull request Oct 30, 2019
Closed
@rwedge rwedge mentioned this pull request Oct 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwedge rwedge rwedge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thehomebrewnerd @CLAassistant @rwedge